Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use '-XX:+UseG1GC -XX:+UseStringDeduplication' in default java.jdt.ls.vmargs #195

Closed
fbricon opened this issue May 1, 2017 · 1 comment
Closed

Use '-XX:+UseG1GC -XX:+UseStringDeduplication' in default java.jdt.ls.vmargs #195

fbricon opened this issue May 1, 2017 · 1 comment
Assignees
@fbricon
Labels
enhancement
Milestone
Late April 2017

Comments

@fbricon
Copy link
Collaborator

fbricon commented May 1, 2017 •
edited

Eclipse distros use -XX:+UseG1GC -XX:+UseStringDeduplication by default to enable string deduplication and decrease memory footprint. I believe we should enable the same settings by default in java.jdt.ls.vmargs.

@gorkem wdyt?
@fbricon fbricon self-assigned this May 1, 2017
fbricon added a commit to fbricon/vscode-java that referenced this issue May 1, 2017
@fbricon
Enable String deduplication by default. Fixes redhat-developer#195
250c7d6 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon closed this as completed in 59245d3 May 1, 2017
@fbricon
Copy link
Collaborator Author

fbricon commented May 3, 2017

so I loaded the vert.x code base, opened 1 file (DatagramPacket.java), loaded codelenses.
After running GC with jcmd <pid> GC.run , without string dedup, top shows me the java process takes ~720MB of memory (+/- 10MB).

With string dedup enabled, same steps, memory after GC takes ~320MB give or take

@fbricon fbricon mentioned this issue May 3, 2017
Closed
@fbricon fbricon added this to the Late April 2017 milestone May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
enhancement
Projects
None yet
Milestone
Late April 2017
Development

No branches or pull requests
1 participant
@fbricon