Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The quickfix doesn't suggest the correct import type when the unresolved type is in an anonymous class #2034

Closed
testforstephen opened this issue Jul 20, 2021 · 6 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#1822
Closed

The quickfix doesn't suggest the correct import type when the unresolved type is in an anonymous class #2034

testforstephen opened this issue Jul 20, 2021 · 6 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#1822
Assignees
@snjeza
Labels
upstream
Milestone
Mid August 2021

Comments

@testforstephen
Copy link
Collaborator

The quick fix does not provide a valid fix suggestion when the unresolved type is in an anonymous class. Here is the screenshot.

Screen.Recording.2021-07-20.at.22.15.45.mov

Originally reported by @@hasen6 at microsoft/vscode-java-pack#691
@testforstephen testforstephen mentioned this issue Jul 20, 2021
Closed
@snjeza
Copy link
Contributor

snjeza commented Jul 21, 2021

This is an upstream issue. I can reproduce it in Eclipse 4.21 build I20210719-1800

@snjeza
Copy link
Contributor

snjeza commented Jul 22, 2021

Related bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=574982

@snjeza
Copy link
Contributor

snjeza commented Jul 24, 2021

https://bugs.eclipse.org/bugs/show_bug.cgi?id=574982 has been fixed. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=574982#c10

@snjeza snjeza mentioned this issue Jul 25, 2021
Open
snjeza added a commit to snjeza/eclipse.jdt.ls that referenced this issue Jul 27, 2021
@snjeza
Update target platform to 4.21 build I20210726-1800
a62bb5e 
- fixes redhat-developer/vscode-java#2034
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=574982

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@snjeza snjeza mentioned this issue Jul 27, 2021
Merged
rgrunber pushed a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue Jul 27, 2021
@snjeza @rgrunber
Update target platform to 4.21 build I20210726-1800
2fcfe57 
- fixes redhat-developer/vscode-java#2034
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=574982

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@hasen6
Copy link

hasen6 commented Jul 28, 2021 •
edited

@testforstephen All the threads opened regarding this issue seem to now be closed but the original bug in VSCode still exists. Am I to assume an update is forthcoming?

@testforstephen testforstephen added this to the End July 2021 milestone Jul 28, 2021
@testforstephen
Copy link
Collaborator Author

@hasen6 Yes, Language Support for Java(TM) by Red Hat extension will have a new version 0.81.0 to include this fix.

@hasen6
Copy link

hasen6 commented Jul 28, 2021

@testforstephen Oh ok great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snjeza snjeza

Labels
upstream
Projects
None yet
Milestone
Mid August 2021
Development

Successfully merging a pull request may close this issue.

Update target platform to 4.21 build I20210726-1800 snjeza/eclipse.jdt.ls
3 participants
@snjeza @testforstephen @hasen6