Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CancellationException in output log #213

Closed
aeschli opened this issue May 16, 2017 · 3 comments
Closed

CancellationException in output log #213

aeschli opened this issue May 16, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@aeschli
Copy link
Collaborator

aeschli commented May 16, 2017

Language support for Java ™ for Visual Studio Code, v0.4.0

  • java version "1.8.0_131"
  • created a sample maven app
  • doing code assist in AppTest.java
    public void testApp2()
    {
        String s = "Hello";
        s.|<assist here

    }
  • shows the folloing exception in the Java output.
    No harm seems done, all works fine, but confuses a bit.
java.util.concurrent.CancellationException
	at org.eclipse.lsp4j.jsonrpc.CompletableFutures.lambda$computeAsync$0(CompletableFutures.java:29)
	at org.eclipse.jdt.ls.core.internal.CancellableProgressMonitor.isCanceled(CancellableProgressMonitor.java:36)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.checkCancel(CompletionEngine.java:1818)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.acceptType(CompletionEngine.java:1315)
	at org.eclipse.jdt.internal.core.SearchableEnvironmentRequestor.acceptType(SearchableEnvironmentRequestor.java:115)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypesInBinaryPackage(NameLookup.java:1087)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypes(NameLookup.java:1021)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypes(NameLookup.java:964)
	at org.eclipse.jdt.internal.core.NameLookup.findAllTypes(NameLookup.java:330)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypes(NameLookup.java:997)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypes(NameLookup.java:964)
	at org.eclipse.jdt.internal.core.SearchableEnvironment.findTypes(SearchableEnvironment.java:670)
	at org.eclipse.jdt.internal.core.SearchableEnvironment.findTypes(SearchableEnvironment.java:466)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.findTypesAndPackages(CompletionEngine.java:10832)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.completionOnSingleNameReference(CompletionEngine.java:3451)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.complete(CompletionEngine.java:1849)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.complete(CompletionEngine.java:2075)
	at org.eclipse.jdt.internal.core.Openable.codeComplete(Openable.java:131)
	at org.eclipse.jdt.internal.core.CompilationUnit.codeComplete(CompilationUnit.java:357)
	at org.eclipse.jdt.internal.core.CompilationUnit.codeComplete(CompilationUnit.java:345)
	at org.eclipse.jdt.ls.core.internal.handlers.CompletionHandler.computeContentAssist(CompletionHandler.java:79)
	at org.eclipse.jdt.ls.core.internal.handlers.CompletionHandler.lambda$0(CompletionHandler.java:39)
	at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602)
	at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577)
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442)
	at java.lang.Thread.run(Thread.java:748)
java.util.concurrent.CancellationException
	at org.eclipse.lsp4j.jsonrpc.CompletableFutures.lambda$computeAsync$0(CompletableFutures.java:29)
	at org.eclipse.jdt.ls.core.internal.CancellableProgressMonitor.isCanceled(CancellableProgressMonitor.java:36)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.checkCancel(CompletionEngine.java:1818)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.acceptType(CompletionEngine.java:1315)
	at org.eclipse.jdt.internal.core.SearchableEnvironmentRequestor.acceptType(SearchableEnvironmentRequestor.java:115)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypesInBinaryPackage(NameLookup.java:1087)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypes(NameLookup.java:1021)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypes(NameLookup.java:964)
	at org.eclipse.jdt.internal.core.NameLookup.findAllTypes(NameLookup.java:330)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypes(NameLookup.java:997)
	at org.eclipse.jdt.internal.core.NameLookup.seekTypes(NameLookup.java:964)
	at org.eclipse.jdt.internal.core.SearchableEnvironment.findTypes(SearchableEnvironment.java:670)
	at org.eclipse.jdt.internal.core.SearchableEnvironment.findTypes(SearchableEnvironment.java:466)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.findTypesAndPackages(CompletionEngine.java:10832)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.completionOnSingleNameReference(CompletionEngine.java:3451)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.complete(CompletionEngine.java:1849)
	at org.eclipse.jdt.internal.codeassist.CompletionEngine.complete(CompletionEngine.java:2075)
	at org.eclipse.jdt.internal.core.Openable.codeComplete(Openable.java:131)
	at org.eclipse.jdt.internal.core.CompilationUnit.codeComplete(CompilationUnit.java:357)
	at org.eclipse.jdt.internal.core.CompilationUnit.codeComplete(CompilationUnit.java:345)
	at org.eclipse.jdt.ls.core.internal.handlers.CompletionHandler.computeContentAssist(CompletionHandler.java:79)
	at org.eclipse.jdt.ls.core.internal.handlers.CompletionHandler.lambda$0(CompletionHandler.java:39)
	at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602)
	at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577)
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442)
	at java.lang.Thread.run(Thread.java:748)
@fbricon fbricon added the bug label May 16, 2017
@fbricon fbricon added this to the End May 2017 milestone May 16, 2017
@fbricon fbricon self-assigned this May 16, 2017
@fbricon
Copy link
Collaborator

fbricon commented May 19, 2017

Doing my best to try to reproduce the issue, but no dice so far. Even putting a breakpoint on the server then hitting escape on the vscode side doesn't generate the CancellationException.

@aeschli do you see the problem consistently?

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue May 19, 2017
fbricon added a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue May 19, 2017
@fbricon
Copy link
Collaborator

fbricon commented May 19, 2017

Even though I can't reproduce the issue, I made sure no exception is propagated when calling monitor.isCancelled() in eclipse-jdtls/eclipse.jdt.ls@79e6421

@aeschli
Copy link
Collaborator Author

aeschli commented May 22, 2017

@fbricon Trying again, I also can't reproduce it anymore today.
From how I remember it, the CancellationException can occur with every method that takes a progress monitor. When you use a method that takes an IProgressMonitor you need to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants