Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets on top again, covering real proposals #216

Closed
aeschli opened this issue May 17, 2017 · 5 comments
Closed

Snippets on top again, covering real proposals #216

aeschli opened this issue May 17, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@aeschli
Copy link
Collaborator

aeschli commented May 17, 2017

From @aeschli on May 16, 2017 15:21

Playing around with the Java language server, I see that code assist shows snippets again on the top, covering all real proposals:

image

I need to scroll down to learn about the object before the dot.
image

Copied from original issue: microsoft/vscode#26756

@aeschli
Copy link
Collaborator Author

aeschli commented May 17, 2017

From @jrieken on May 16, 2017 15:48

Settings? Java-Specific?

@aeschli
Copy link
Collaborator Author

aeschli commented May 17, 2017

From @jrieken on May 16, 2017 16:3

That's the sorting the extension wanted, all semantic suggestions have zzzzzzadf as sort text, the suggestions don't. By default we sort snippets inline and only demote when they are equal to other suggestions.

screen shot 2017-05-16 at 18 00 25

@aeschli
Copy link
Collaborator Author

aeschli commented May 17, 2017

@jrieken Thanks Joh for digging. Sorry, I didn't expect the Java extension to set the sort text.
Moving to the Java extension. Any reason to set the sort text?

@gorkem
Copy link
Contributor

gorkem commented May 17, 2017

Sort text is set to mimic a relevancy to the context where completion request is invoked. I am not sure if we can have an alternate way to manage the relevancy on Completions.

@fbricon
Copy link
Collaborator

fbricon commented May 17, 2017

Changing sort text to use numerical values instead of zzzz*:
screen shot 2017-05-17 at 10 45 03 am

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue May 17, 2017
@fbricon fbricon self-assigned this May 17, 2017
@fbricon fbricon added this to the End May 2017 milestone May 17, 2017
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue May 17, 2017
fbricon added a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants