Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code snippets use deprecated, internal syntax #217

Closed
fbricon opened this issue May 18, 2017 · 1 comment
Closed

Code snippets use deprecated, internal syntax #217

fbricon opened this issue May 18, 2017 · 1 comment
Assignees
Milestone

Comments

@fbricon
Copy link
Collaborator

fbricon commented May 18, 2017

copied from microsoft/vscode#26834

in vscode 1.13, with snippets like

"Class Definition": {
    "prefix": "class",
    "body": [
      "/**",
      " * ${name}",
      " */",
      "public class ${name} {",
      "",
      "\tpublic ${name} (${parameters}) {",
      "\t\t$0",
      "\t}",
      "}"
    ],
    "description": "Class Definition"
  },

when selecting that template during completion, all parameters are gone now.

from @jrieken

The snippet above uses the internal syntax that we never documented and never made official. 
We have deprecated that in Nov 16 and are now removing support. I did create an adoption for 
item for your extensions and it seems to be closed: redhat-developer/vscode-java#99.

The new snippet syntax is TextMate like and defined here: 
https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax
@fbricon fbricon added this to the End May 2017 milestone May 18, 2017
@fbricon fbricon self-assigned this May 18, 2017
fbricon added a commit to fbricon/vscode-java that referenced this issue May 18, 2017
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon
Copy link
Collaborator Author

fbricon commented May 18, 2017

While PR #218 fixes this particular issue, using autocompletion right in the middle of an inserted snippet is broken, see microsoft/vscode#26869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant