Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project configuration is not updated after modifying the build file in v1.8.0 #2566

Closed
skazantsev opened this issue Jul 14, 2022 · 0 comments · Fixed by #2567
Closed

Project configuration is not updated after modifying the build file in v1.8.0 #2566

skazantsev opened this issue Jul 14, 2022 · 0 comments · Fixed by #2567
Assignees
Labels
Milestone

Comments

@skazantsev
Copy link

Hey,

Looks like there's regression in project update introduced in Support project update selection.

Steps to reproduce

  1. Open a maven project. I used https://github.com/jenkins-docs/simple-java-maven-app.
  2. Modify & save pom.xml, the IDE shows a dialog A build file was modified. Do you want to synchronize the Java classpath/configuration?.
  3. Click Yes.

Expected result

The project configuration update is requested, the project is in sync with pom.xml.

Actual result

The project configuration update is not requested, the project is out of sync with pom.xml.

Workaround

Run Update project configuration command manually.

Environment

  • Operating System: RHEL
  • JDK version: 17
  • Visual Studio Code version: 1.68.1
  • Java extension version: 1.8.0

Additional details

The command is originated from eclipse.jdt.ls/StandardProjectsManager.java, so the uri argument is not an instance of Uri but an object like { uri: "<path>/pom.xml" }.

Previously, this case was handled in the if (!(resource instanceof Uri)) branch.

nit: it may also worth fixing the type of uris argument, the actual type seems to be Uri | Uri[] | { uri: string } | Array<{ uri: string }>.

@skazantsev skazantsev changed the title Project configuration are not updated after modifying the build file in v1.8.0 Project configuration is not updated after modifying the build file in v1.8.0 Jul 14, 2022
@jdneo jdneo self-assigned this Jul 15, 2022
@jdneo jdneo added the bug label Jul 15, 2022
@jdneo jdneo added this to the End July 2022 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants