Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support project update selection #2513

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Conversation

jdneo
Copy link
Collaborator

@jdneo jdneo commented Jun 17, 2022

  • If no uri is passed into the projectConfigurationUpdate() function,
    show a quick pick list and let user select which projects to update.
  • If there is only one project in the workspace, project update request
    for that project will directly send to server without asking.

part of #2473, requires eclipse-jdtls/eclipse.jdt.ls#2131

Signed-off-by: sheche sheche@microsoft.com

- If no uri is passed into the projectConfigurationUpdate() function,
  show a quick pick list and let user select which projects to update.
- If there is only one project in the workspace, project update request
  for that project will directly send to server without asking.

Signed-off-by: sheche <sheche@microsoft.com>
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one style-based suggestion for ease of reading the cases and at best avoiding performing some unnecessary logic in certain cases.

src/standardLanguageClient.ts Outdated Show resolved Hide resolved
Signed-off-by: sheche <sheche@microsoft.com>
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to squash and merge when ready.

@jdneo jdneo merged commit eefebb5 into redhat-developer:master Jun 22, 2022
@jdneo jdneo deleted the cs/issue-2473 branch June 22, 2022 01:51
@rgrunber rgrunber added this to the End June 2022 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants