Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting server tasks uses compare function that always returns zero #2627

Closed
datho7561 opened this issue Aug 15, 2022 · 3 comments · Fixed by #2934
Closed

Sorting server tasks uses compare function that always returns zero #2627

datho7561 opened this issue Aug 15, 2022 · 3 comments · Fixed by #2934

Comments

@datho7561
Copy link
Contributor

https://github.com/redhat-developer/vscode-java/blob/master/src/serverTasks.ts#L37

Unless I'm missing something, this compare function seems to always return zero. This doesn't seem like the correct behaviour.

@datho7561 datho7561 added the bug label Aug 15, 2022
@rgrunber
Copy link
Member

That definitely looks like a typo.

@priyangbhavsar
Copy link
Contributor

Hello @datho7561 , I am willing to take this issue as the first contribution

@datho7561
Copy link
Contributor Author

Sounds good. Let me know if you have any questions, and feel free to ping me in the review

@rgrunber rgrunber added this to the Mid March 2023 milestone Feb 21, 2023
@rgrunber rgrunber linked a pull request Feb 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants