server task sorting issue fix #2934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Priyang Bhavsar <bhavsarpriyang9999@gmail.com>
datho7561
approved these changes
Feb 15, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Yes, this works great! Now when you load in a large project (such as eclipse.jdt.ls), it's much easier to keep track of the progress. Thanks @priyangbhavsar !
Collaborator
|
@datho7561 can you share a gif showing before/after the change? |
Contributor
|
Old: the progress is usually at the top but not always:
New: the progress is always on the bottom:
|
Collaborator
|
well the code explicitly says "// make sure in-progress items are always at the end" |
Member
|
Maybe there was some point when the terminal had auto-scrolling issues ? I could see wanting to place in-progress items at the top in that case. However, having them at the bottom is a huge improvement. I think we can merge after tomorrow's release. |
Contributor
|
great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the sorting logic of server tasks
issue : Sorting server tasks uses compare function that always returns zero #2627