Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't propose code snippets inside comments #2867

Closed
fbricon opened this issue Jan 10, 2023 · 3 comments · Fixed by #3253
Closed

Don't propose code snippets inside comments #2867

fbricon opened this issue Jan 10, 2023 · 3 comments · Fixed by #3253

Comments

@fbricon
Copy link
Collaborator

fbricon commented Jan 10, 2023

Code snippets inside comments are fairly noisy (they get in the way of JBang directives). I don't think there's a valid reason to propose them there.
Screenshot 2023-01-10 at 09 16 01

@jdneo
Copy link
Collaborator

jdneo commented Jan 11, 2023

They are static snippets defined here: https://github.com/redhat-developer/vscode-java/blob/master/snippets/java.json.

If we want to make them more context-aware, we might need to consider making them become server-side snippets - Maybe unregistered the client static snippets once server is ready.

@rgrunber
Copy link
Member

Maybe we could re-use some of the work from eclipse/lsp4mp#338 ?

@datho7561
Copy link
Contributor

datho7561 commented Jan 11, 2023

If we are interested in doing this, I could look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants