Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vscode-extension-proposals for recommendations #3099

Closed
robstryker opened this issue May 10, 2023 · 0 comments · Fixed by #3101
Closed

Use vscode-extension-proposals for recommendations #3099

robstryker opened this issue May 10, 2023 · 0 comments · Fixed by #3101
Milestone
End May 2023

Comments

@robstryker
Copy link
Contributor

[provide a description of the issue]
It may be worth using vscode-extension-proposals to handle the display of recommendations for other extensions, as this unifies the recommendation logic among several extensions and presents a better user experience by default, but also allows for the ability to improve a poor user experience caused by multiple extensions behaving differently in the future if some poor experience is discovered.

Environment
  • Operating System:
  • JDK version:
  • Visual Studio Code version:
  • Java extension version:
Steps To Reproduce
  1. [step 1]
  2. [step 2]

[Please attach a sample project reproducing the error]
Please attach logs

Current Result
Expected Result
Additional Informations
robstryker added a commit to robstryker/vscode-java that referenced this issue May 10, 2023
@robstryker
Fixes redhat-developer#3099 - use vscode-extension-proposals to unify…
f1394be 
… proposal logic

Signed-off-by: Rob Stryker <rob@oxbeef.net>
robstryker added a commit to robstryker/vscode-java that referenced this issue May 18, 2023
@robstryker
Fixes redhat-developer#3099 - use vscode-extension-proposals to unify…
6ac6388 
… proposal logic

Signed-off-by: Rob Stryker <rob@oxbeef.net>

Upversion proposals dependency to 0.0.16

Signed-off-by: Rob Stryker <rob@oxbeef.net>

Upversion to newest extension-proposals 0.0.18

Signed-off-by: Rob Stryker <rob@oxbeef.net>

Use newest extension-proposals 0.0.21

Signed-off-by: Rob Stryker <rob@oxbeef.net>
@rgrunber rgrunber linked a pull request May 19, 2023 that will close this issue
Fixes #3099 - use vscode-extension-proposals to unify proposal logic #3101
Merged
rgrunber pushed a commit that referenced this issue May 19, 2023
@robstryker
Use vscode-extension-proposals to unify proposal logic (#3101)
02deb55 
- Use newest extension-proposals 0.0.21
- Fixes #3099 

Signed-off-by: Rob Stryker <rob@oxbeef.net>
@rgrunber rgrunber added this to the End May 2023 milestone May 19, 2023
gayanper pushed a commit to gayanper/vscode-java that referenced this issue May 27, 2023
@robstryker @gayanper
Use vscode-extension-proposals to unify proposal logic (redhat-develo…
31399dd 
…per#3101)

- Use newest extension-proposals 0.0.21
- Fixes redhat-developer#3099 

Signed-off-by: Rob Stryker <rob@oxbeef.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
End May 2023
Development

Successfully merging a pull request may close this issue.

Fixes #3099 - use vscode-extension-proposals to unify proposal logic robstryker/vscode-java
2 participants
@robstryker @rgrunber