Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Maven Archetype projects #331

Closed
jgeorgeson opened this issue Oct 15, 2017 · 2 comments
Closed

Better support for Maven Archetype projects #331

jgeorgeson opened this issue Oct 15, 2017 · 2 comments
Assignees
Labels

Comments

@jgeorgeson
Copy link

With java.configuration.updateBuildConfiguration set to automatic, the src/main/resources/archetype-resources/pom.xml is built, creating a src/main/resources/archetype-resources/target folder that is then included into the packaged archetype jar. It's nice to have the Eclipse project files (.settings folder, .classpath, and .project) created inside the archetype-resources so that projects generated from my archetypes are Eclipse-ready out of the box, but the target folder definitely doesn't belong.

Environment
  • Operating System: Windows
  • JDK version:
  • Visual Studio Code version:
  • Java extension version:
Steps To Reproduce
  1. Create a project with mvn archetype:generate -DarchetypeArtifactId=maven-archetype-archetype
  2. Open project in VS Code and set to automatically update build configuration when build files are changed.
Additional Informations

https://maven.apache.org/archetype/maven-archetype-plugin/specification/archetype.html

@fbricon
Copy link
Collaborator

fbricon commented Nov 1, 2017

I can't get it to create src/main/resources/archetype-resources/target (which would be wrong), however setting java.configuration.updateBuildConfiguration to automatic makes jdt.ls go into an infinite loop of project updates, which is definitely wayyyy more wrong

@fbricon fbricon added the bug label Nov 1, 2017
@fbricon fbricon self-assigned this Nov 1, 2017
@fbricon fbricon added this to the End October 2017 milestone Nov 1, 2017
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Nov 1, 2017
See redhat-developer/vscode-java#331

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue Nov 1, 2017
See redhat-developer/vscode-java#331

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@jgeorgeson
Copy link
Author

Thanks, can confirm I'm not seeing that target folder show up under src/main/archetype-resources anymore in 0.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants