Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host textmate definition for kotlin language #3334

Closed
jdneo opened this issue Oct 7, 2023 · 3 comments · Fixed by #3377
Closed

Host textmate definition for kotlin language #3334

jdneo opened this issue Oct 7, 2023 · 3 comments · Fixed by #3377

Comments

@jdneo
Copy link
Collaborator

jdneo commented Oct 7, 2023

Buildship recently added experimental feature -- a language server for the *.kts files, which works for the gradle kts scripts.

It introduces a textmate definition for kotlin language: https://github.com/eclipse/buildship/blob/master/org.eclipse.buildship.kotlindsl.provider/kotlin.tmLanguage.json

Should we consider hosting this file in the extension? Currently there is no hightlighting when user opens *.kts files.

@jdneo
Copy link
Collaborator Author

jdneo commented Oct 7, 2023

@rgrunber BTW, I saw we already host definitions for .java and .properties. While the VS Code repo also has .java hosted. I forgot the story to re-host another .java definition. Could you remind me about that?

@rgrunber
Copy link
Member

rgrunber commented Oct 10, 2023

See microsoft/vscode#187725 (comment), #3200, https://github.com/microsoft/vscode/pull/188361/files .

Basically the original grammar provided by atom/language-java became read only at the end of 2022. This was the one VS Code was using. We raised an issue about fixing it in VS Code (we had some proposed improvements) but the proposal was for vscode-java to "own" the grammar. Now VS Code seems to be updating based on ours.

I think it makes sense to host the kotlin grammar it in vscode-java.

@jdneo
Copy link
Collaborator Author

jdneo commented Oct 11, 2023

Thank you for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants