Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove folding markers #369

Closed
aeschli opened this issue Nov 16, 2017 · 3 comments
Closed

Remove folding markers #369

aeschli opened this issue Nov 16, 2017 · 3 comments
Assignees
@fbricon
Labels
debt
Milestone
Mid December 2017

Comments

@aeschli
Copy link
Collaborator

aeschli commented Nov 16, 2017 •
edited

The folding markers should be removed from language-configuration.java as they are already provided by the built-in Java extension.

Also they have a bug as they match

    System.out.println("<editor-fold>");
    System.out.println("Hello, world");
    System.out.println("</editor-fold>");

Same bug is in the built-in Java extension, but fixed in 1.19
@aeschli aeschli mentioned this issue Nov 16, 2017
Closed
@fbricon
Copy link
Collaborator

fbricon commented Nov 16, 2017

I'm happy to remove those once vscode 1.19 is out

@aeschli
Copy link
Collaborator Author

aeschli commented Nov 16, 2017 •
edited

But better fix it. Right now having it installed on a vscode insiders (with the fix) brings back the bug.

fbricon added a commit that referenced this issue Nov 17, 2017
@fbricon
Copy vscode region folding patterns
883b870 
This immediately fixes the issue in #369, but region patterns
will be removed in vscode-java 0.16.0, to avoid duplication.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon
Copy link
Collaborator

fbricon commented Nov 17, 2017

The bug has been fixed in master by copying vscode's patterns.
I'll keep this issue opened as a reminder to remove those patterns after the end of november release. vscode-java 0.16.0 will be released after vscode 1.19.

@fbricon fbricon added this to the Mid December 2017 milestone Nov 17, 2017
@fbricon fbricon added the debt label Nov 17, 2017
@fbricon fbricon self-assigned this Nov 17, 2017
fbricon added a commit to fbricon/vscode-java that referenced this issue Dec 1, 2017
@fbricon
Remove unnecessary region support
414baa0 
...since this is now provided by upstream VSCode.

Fixes redhat-developer#369

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon mentioned this issue Dec 1, 2017
Merged
fbricon added a commit that referenced this issue Dec 1, 2017
@fbricon
Remove unnecessary region support
3c0a46b 
...since this is now provided by upstream VSCode.

Fixes #369

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
debt
Projects
None yet
Milestone
Mid December 2017
Development

No branches or pull requests
2 participants
@fbricon @aeschli