Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*.vsix files built by Jenkins are ~30% larger than those built locally #438

Closed
fbricon opened this issue Feb 13, 2018 · 3 comments
Closed

*.vsix files built by Jenkins are ~30% larger than those built locally #438

fbricon opened this issue Feb 13, 2018 · 3 comments
Assignees
@fbricon
Labels
build/infra
Milestone
Mid February 2018

Comments

@fbricon
Copy link
Collaborator

fbricon commented Feb 13, 2018

*.vsix files built by Jenkins are currently ~10MB larger than those built locally (45MB vs 34MB).

Size suddenly increased with java-0.9.0-365.vsix, in August 2017, see http://download.jboss.org/jbosstools/jdt.ls/staging/

That sucks!
@fbricon
Copy link
Collaborator Author

fbricon commented Feb 13, 2018

Locally, I do
rm -rf server node_modules; npm install; gulp build_server; npm run vscode:prepublish; vsce package

@snjeza
Copy link
Contributor

snjeza commented Feb 14, 2018

*.vsix built by Jenkins includes several unnecessary files in the extension/server/config_linux/ directory

       0  02-13-2018 13:34   extension/server/config_linux/org.eclipse.core.runtime/.manager/.fileTableLock
        0  02-13-2018 13:34   extension/server/config_linux/org.eclipse.core.runtime/.manager/.tmp8719294041415966503.instance
        0  02-13-2018 13:34   extension/server/config_linux/org.eclipse.equinox.app/.manager/.fileTableLock
        0  02-13-2018 13:34   extension/server/config_linux/org.eclipse.equinox.app/.manager/.tmp3872751700109476653.instance
   175280  02-13-2018 13:34   extension/server/config_linux/org.eclipse.equinox.launcher/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.700.v20180124-1426/eclipse_1702.so
        0  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/.manager/.fileTableLock
    32905  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/41/0/.cp/lib/java9api.jar
    74698  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/44/0/.cp/jdi.jar
   944329  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/44/0/.cp/jdimodel.jar
     8960  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/47/0/.cp/lib/launchingsupport.jar
   319052  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/48/0/.cp/lib/jsoup-1.9.2.jar
    61920  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/48/0/.cp/lib/remark-1.0.0.jar
    18580  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/archetype-catalog-2.4.jar
   173392  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/archetype-common-2.4.jar
    23120  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/archetype-descriptor-2.4.jar
    16647  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/archetype-registry-2.4.jar
   588337  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/commons-collections-3.2.2.jar
   173587  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/commons-io-2.2.jar
   207723  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/commons-lang-2.1.jar
   313898  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/dom4j-1.6.1.jar
    26605  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/jchardet-1.0.jar
   153253  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/jdom-1.0.jar
    29735  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/maven-invoker-2.1.1.jar
    65261  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/oro-2.0.8.jar
     7885  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/plexus-velocity-1.1.8.jar
   392124  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/52/0/.cp/velocity-1.5.jar
    26720  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/56/0/.cp/indexer-artifact-3.1.0.jar
   199480  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/56/0/.cp/indexer-core-3.1.0.jar
   822794  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/56/0/.cp/lucene-core-2.4.1.jar
    91156  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/56/0/.cp/lucene-highlighter-2.4.1.jar
    50624  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/aether-connector-okhttp-0.17.2.jar
    44908  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/cdi-api-1.0.jar
    53820  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/commons-cli-1.4.jar
   208700  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/commons-io-2.5.jar
   479881  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/commons-lang3-3.5.jar
  2442625  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/guava-20.0.jar
   423560  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/guice-4.0-no_aop.jar
     5848  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/jsr250-api-1.0.jar
    54926  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-artifact-3.5.2.jar
    14787  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-builder-support-3.5.2.jar
   290364  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-compat-3.5.2.jar
   630341  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-core-3.5.2.jar
    97283  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-embedder-3.5.2.jar
   164979  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-model-3.5.2.jar
   179704  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-model-builder-3.5.2.jar
    47645  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-plugin-api-3.5.2.jar
    27463  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-repository-metadata-3.5.2.jar
   146241  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-resolver-api-1.1.0.jar
    42834  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-resolver-connector-basic-1.1.0.jar
   184624  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-resolver-impl-1.1.0.jar
    67722  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-resolver-provider-3.5.2.jar
    35850  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-resolver-spi-1.1.0.jar
    30961  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-resolver-transport-wagon-1.1.0.jar
   158930  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-resolver-util-1.1.0.jar
    44575  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-settings-3.5.2.jar
    43152  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-settings-builder-3.5.2.jar
   163692  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/maven-shared-utils-3.1.0.jar
   394987  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/okhttp-3.7.0.jar
    81088  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/okio-1.12.0.jar
   379175  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/org.eclipse.sisu.inject-0.3.3.jar
   205307  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/org.eclipse.sisu.plexus-0.3.3.jar
     8482  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/plexus-build-api-0.0.7.jar
    13350  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/plexus-cipher-1.7.jar
    52684  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/plexus-classworlds-2.5.2.jar
     4288  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/plexus-component-annotations-1.7.1.jar
    78876  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/plexus-interpolation-1.24.jar
    27703  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/plexus-sec-dispatcher-1.4.jar
   261617  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/plexus-utils-3.1.0.jar
    11606  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/wagon-file-2.12.jar
    55170  02-13-2018 13:34   extension/server/config_linux/org.eclipse.osgi/57/0/.cp/jars/wagon-provider-api-2.12.jar

fbricon added a commit that referenced this issue Feb 14, 2018
@fbricon
Run tests *after* packaging
16a8f10 
The goal is to avoid packaging unnecessary files in the extension/server/config_linux/ 
See #438
@fbricon fbricon mentioned this issue Feb 15, 2018
Open
@fbricon fbricon self-assigned this Feb 15, 2018
@fbricon fbricon added this to the Mid February 2018 milestone Feb 15, 2018
@fbricon
Copy link
Collaborator Author

fbricon commented Feb 15, 2018

Build size is now back to the regular 34MB, after switching the test and packaging phases

http://download.jboss.org/jbosstools/jdt.ls/staging/

@fbricon fbricon closed this as completed Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
build/infra
Projects
None yet
Milestone
Mid February 2018
Development

No branches or pull requests
2 participants
@fbricon @snjeza