Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Outline support #586

Closed
jrieken opened this issue Jul 9, 2018 · 3 comments
Closed

Add Outline support #586

jrieken opened this issue Jul 9, 2018 · 3 comments

Comments

@jrieken
Copy link

jrieken commented Jul 9, 2018

With the 1.25 release we have finalised the API for the outline tree. A DocumentSymbolProvider should now return document symbols which can represent a hierarchy and that can differentiate between the full range of a symbol and the selection range, e.g. the name of a function.

Note that we synthesise trees using range-containment when a provider returns SymbolInformation-objects and that that isn't perfect. Adopting the new API makes the outline more robust and support features like follow-cursor and diagnostics association.

Let me know if need more information is needed. Happy Coding!

@jrieken
Copy link
Author

jrieken commented Jul 9, 2018

This also depends on microsoft/language-server-protocol#327

@tsmaeder
Copy link

tsmaeder commented Sep 5, 2018

This issue should be on https://github.com/eclipse/eclipse.jdt.ls

@fbricon
Copy link
Collaborator

fbricon commented Sep 5, 2018

Opened eclipse-jdtls/eclipse.jdt.ls#780 upstream

@fbricon fbricon changed the title Adopt improved DocumentSymbolProvider API Add Outline support Sep 5, 2018
@fbricon fbricon added this to the Mid September 2018 milestone Sep 5, 2018
fbricon added a commit that referenced this issue Sep 17, 2018
Fixes #586

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit that referenced this issue Sep 17, 2018
Fixes #586

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants