Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing constantly trigger validating documents/building workspace job #996

Open
testforstephen opened this issue Jul 22, 2019 · 4 comments
Assignees
Labels

Comments

@testforstephen
Copy link
Collaborator

In VS Code editor, just typing an empty line, the status bar constantly show validating documents, publish diagnostics, building workspace. Reference the UX of Eclipse, typing there doesn't trigger building unless you save the file. So building workspace looks like an unnecessary step during editing. But if you trigger save action, it should be triggered if auto build is enabled.

@testforstephen
Copy link
Collaborator Author

testforstephen commented Jul 23, 2019

Another complaint from the user is the status bar continuously flashes an update when typing code. Validating Documents, Publishing Diagnostics are very specific technical implementation, the user doesn't need the details of this level when typing code.

@snjeza
Copy link
Contributor

snjeza commented Jul 23, 2019

So building workspace looks like an unnecessary step during editing. But if you trigger save action, it should be triggered if auto build is enabled.

The issue happens because the document/didChange, document/didOpen and document/didClose commands run as a workspace runnable. The workspace runnable schedules AutoBuildJob. AutoBuildJob fires the PRE_BUILD and POST_BUILD events although a workspace build isn't called. See AutoBuildJob.doBuild(IProgressMonitor). That's way you can see the "Build Workspace" message in the status line although a workspace build isn't called.
In my opinion, this issue is an Eclipse upstream issue.

In VS Code editor, just typing an empty line, the status bar constantly show validating documents, publish diagnostics, building workspace

You can disable these messages with the following property:

"java.progressReports.enabled": false,

@snjeza
Copy link
Contributor

snjeza commented Jul 23, 2019

@Eskibear
Copy link
Contributor

Same here for me...

In VS Code editor, just typing an empty line, the status bar constantly show validating documents, publish diagnostics, building workspace

I've been using VSCode to edit Java code for a while, these messages constantly update the status bar as long as I'm typing. The problem is, these messages are providing no help but distracting me from coding.

For the upstream issue, is there any update?
Is it possible to do some improvements on this extension's side, to filter out the distracting messages by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants