New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error on canceling source actions #1292

Merged

fbricon merged 1 commit into redhat-developer:master from Eskibear:fix-npe

Feb 20, 2020

Contributor

Eskibear commented Feb 20, 2020

Repro steps:

open a .java file, right click, Source Actions...
select Generate Getters and Setters...
when dropdown list occurs, press ESC to cancel.
boom! error occurs.

This PR fixs the same error for:

implement/override methods
getters and setters
hashcode() and equals()


          fix error on canceling source actions

c575eeb

Signed-off-by: Yan Zhang <yanzh@microsoft.com>

fbricon added the bug label

fbricon added this to the Early March 2020 milestone

fbricon merged commit 0726970 into redhat-developer:master

Collaborator

fbricon commented Feb 20, 2020

Nice catch @Eskibear, thanks

Eskibear deleted the fix-npe branch

February 21, 2020 01:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment