Add Go to Super Implementation to context menu and command palette #1395

jdneo · 2020-04-16T07:06:02Z

Note: so far, if the selected element has no super implementation, we are not able to show the editor message. This need VS Code to support such API. See: microsoft/vscode#95308

Signed-off-by: Sheng Chen sheche@microsoft.com

fbricon · 2020-04-22T17:43:55Z

The fact the menu item shows up everywhere is very distracting, given than there's no feedback when you call it

jdneo · 2020-04-23T11:04:16Z

@akaroml Let's sync with VS Code team about this issue. We need the API to show the editor message. Otherwise the no-feedback behavior would make user confused.

jdneo · 2020-06-29T02:49:32Z

Update: VS Code team has exposed a new API to show the editor message. I will update this PR after the next VS Code stable version released.

jdneo · 2020-07-10T06:03:28Z

@fbricon @testforstephen PR updated

testforstephen · 2020-07-10T06:41:06Z

src/standardLanguageClient.ts

+				return commands.executeCommand(
+					'editor.action.goToLocations',
+					window.activeTextEditor.document.uri,
+					window.activeTextEditor.selection.active,
+					[],
+					'goto',
+					'No super implementation found'
+				);


CommandsRegistry.registerCommand({ id: 'editor.action.goToLocations', description: { description: 'Go to locations from a position in a file', args: [ { name: 'uri', description: 'The text document in which to start', constraint: URI }, { name: 'position', description: 'The position at which to start', constraint: corePosition.Position.isIPosition }, { name: 'locations', description: 'An array of locations.', constraint: Array }, { name: 'multiple', description: 'Define what to do when having multiple results, either `peek`, `gotoAndPeek`, or `goto' }, { name: 'noResultsMessage', description: 'Human readable message that shows when locations is empty.' }, ] },

Can you also use this function to jump to target location when there is result?

Tried but seems not working. I'm asking in VS Code repo...

Finally it turns out that all the types should be generated by their constructors in API. Simply making the structure won't work.

fbricon · 2020-07-16T09:41:10Z

@snjeza can you check this PR on Theia/Che?

snjeza · 2020-07-16T19:01:00Z

can you check this PR on Theia/Che?

The Go to Super Implementation command doesn't work on Theia.
I am getting:

root ERROR Fail to open 'command:java.action.navigateToSuperImplementation?%5B%7B%22uri%22%3A%22ZmlsZTovLy9ob21lL3NucGUvdGVzdGxzcC9zcHJpbmctcGV0Y2xpbmljL3NyYy9tYWluL2phdmEvb3JnL3NwcmluZ2ZyYW1ld29yay9zYW1wbGVzL3BldGNsaW5pYy9tb2RlbC9CYXNlRW50aXR5LmphdmE%3D%22%2C%22range%22%3A%7B%22start%22%3A%7B%22line%22%3A41%2C%22character%22%3A19%7D%2C%22end%22%3A%7B%22line%22%3A41%2C%22character%22%3A24%7D%7D%7D%5D': validateConstraint@http://localhost:3000/vs/editor/editor.main.js:16167:19
validateConstraints@http://localhost:3000/vs/editor/editor.main.js:16142:31
exports.CommandsRegistry</class_1.prototype.registerCommand/idOrCommand.handler@http://localhost:3000/vs/editor/editor.main.js:81296:29
InstantiationService</InstantiationService.prototype.invokeFunction@http://localhost:3000/vs/editor/editor.main.js:83001:27
execute@http://localhost:3000/66.bundle.js:690:64

jdneo · 2020-07-17T00:52:16Z

Is it caused by the new command introduced in VS Code 1.47.0: editor.action.goToLocations?

fbricon · 2020-07-17T09:44:39Z

package.json

+        },
+        {
+          "command": "java.action.navigateToSuperImplementation",
+          "when": "javaLSReady && editorTextFocus && editorLangId == java",


can we add a supportsGoToSuperImplementation flag, computed dynamically, similar to javaLSReady?

fbricon · 2020-07-17T09:45:20Z

package.json

@@ -735,6 +745,10 @@
          "command": "java.project.import",
          "when": "javaLSReady"
        },
+        {
+          "command": "java.action.navigateToSuperImplementation",
+          "when": "javaLSReady && editorLangId == java"


also check if supportsGoToSuperImplementation

fbricon · 2020-07-17T09:46:33Z

src/standardLanguageClient.ts

-					preserveFocus: true,
-					selection: range,
-				});
+			context.subscriptions.push(commands.registerCommand(Commands.NAVIGATE_TO_SUPER_IMPLEMENTATION_COMMAND, async (location: LinkLocation | Uri) => {


only register if supportsGoToSuperImplementation === true

jdneo · 2020-07-20T04:33:53Z

@fbricon @snjeza Is Theia/Che support the goto super implementation in the hover? I mean, should the flag supportsGoToSuperImplementation used to control the entire goto super implementation feature, or just some scenarios of it. (for example, only for the context menu and command palette)

snjeza · 2020-07-20T14:58:54Z

Is Theia/Che support the goto super implementation in the hover?

It works in Theia without this PR.

fbricon · 2020-07-20T16:40:27Z

Is Theia/Che support the goto super implementation in the hover?

It works in Theia without this PR.

you mean a supportsGoToSuperImplementation flag is not required?

snjeza · 2020-07-20T16:53:57Z

you mean a supportsGoToSuperImplementation flag is not required?

I mean it is required.

snjeza · 2020-07-20T16:55:43Z

@jdneo could you resolve conflicts?

Signed-off-by: Sheng Chen <sheche@microsoft.com>

jdneo · 2020-07-21T10:41:43Z

PR updated. Now it's using window.showTextDocument() to do the navigation. And the go-to-location command will only be used to show the editor message (no super implementation found).

In Che/Theia, since that command so far does not support to show such message, so nothing will happen when no result found.

An issue has been created in the theia repo: eclipse-theia/theia#8212

jdneo · 2020-07-21T10:43:27Z

I also observed that in my machine, sometimes it will take ~10+s to get the result of super implementation. @fbricon @snjeza @testforstephen @Eskibear Have you met that case?

fbricon · 2020-07-21T22:33:21Z

works fine for me

fbricon · 2020-07-21T22:34:49Z

@jdneo thanks!

jdneo force-pushed the cs/super-impl branch from 54fdcaf to 1c50779 Compare July 10, 2020 05:55

testforstephen reviewed Jul 10, 2020

View reviewed changes

jdneo changed the title ~~Add Go to Super Implementation to context menu~~ Add Go to Super Implementation to context menu and command palette Jul 14, 2020

testforstephen approved these changes Jul 14, 2020

View reviewed changes

fbricon reviewed Jul 17, 2020

View reviewed changes

github-actions bot added the has conflicts label Jul 20, 2020

Add Go to Supoer Implementation to context menu and command palette

fd5029c

Signed-off-by: Sheng Chen <sheche@microsoft.com>

jdneo force-pushed the cs/super-impl branch from 41b53fe to fd5029c Compare July 21, 2020 10:35

github-actions bot removed the has conflicts label Jul 21, 2020

fbricon merged commit d6b090f into redhat-developer:master Jul 21, 2020

fbricon added the enhancement label Jul 21, 2020

fbricon added this to the End July 2020 milestone Jul 21, 2020

jdneo deleted the cs/super-impl branch July 22, 2020 01:03

CsCherrYY mentioned this pull request Mar 17, 2022

Support go to supermethod kasecato/vscode-intellij-idea-keybindings#258

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Go to Super Implementation to context menu and command palette #1395

Add Go to Super Implementation to context menu and command palette #1395

jdneo commented Apr 16, 2020

fbricon commented Apr 22, 2020

jdneo commented Apr 23, 2020

jdneo commented Jun 29, 2020

jdneo commented Jul 10, 2020

testforstephen Jul 10, 2020

jdneo Jul 10, 2020

jdneo Jul 14, 2020

fbricon commented Jul 16, 2020

snjeza commented Jul 16, 2020 •

edited

jdneo commented Jul 17, 2020

fbricon Jul 17, 2020 •

edited

fbricon Jul 17, 2020

fbricon Jul 17, 2020

jdneo commented Jul 20, 2020

snjeza commented Jul 20, 2020

fbricon commented Jul 20, 2020

snjeza commented Jul 20, 2020

snjeza commented Jul 20, 2020

jdneo commented Jul 21, 2020

jdneo commented Jul 21, 2020

fbricon commented Jul 21, 2020

fbricon commented Jul 21, 2020

Add Go to Super Implementation to context menu and command palette #1395

Add Go to Super Implementation to context menu and command palette #1395

Conversation

jdneo commented Apr 16, 2020

fbricon commented Apr 22, 2020

jdneo commented Apr 23, 2020

jdneo commented Jun 29, 2020

jdneo commented Jul 10, 2020

testforstephen Jul 10, 2020

Choose a reason for hiding this comment

jdneo Jul 10, 2020

Choose a reason for hiding this comment

jdneo Jul 14, 2020

Choose a reason for hiding this comment

fbricon commented Jul 16, 2020

snjeza commented Jul 16, 2020 • edited

jdneo commented Jul 17, 2020

fbricon Jul 17, 2020 • edited

Choose a reason for hiding this comment

fbricon Jul 17, 2020

Choose a reason for hiding this comment

fbricon Jul 17, 2020

Choose a reason for hiding this comment

jdneo commented Jul 20, 2020

snjeza commented Jul 20, 2020

fbricon commented Jul 20, 2020

snjeza commented Jul 20, 2020

snjeza commented Jul 20, 2020

jdneo commented Jul 21, 2020

jdneo commented Jul 21, 2020

fbricon commented Jul 21, 2020

fbricon commented Jul 21, 2020

snjeza commented Jul 16, 2020 •

edited

fbricon Jul 17, 2020 •

edited