Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to enable Semantic Hightlighting on startup #1419

Merged

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Apr 29, 2020

Display this prompt when the java.semanticHighlighting.enabled preference has not be set explicitely:

Message links to https://github.com/redhat-developer/vscode-java/wiki/Semantic-Highlighting

@fbricon fbricon requested a review from snjeza April 29, 2020 12:32
@fbricon
Copy link
Collaborator Author

fbricon commented Apr 29, 2020

FYI @akaroml @Eskibear

@fbricon fbricon force-pushed the semantic-highlighting-prompt branch from 2b7de66 to 0bf057b Compare April 29, 2020 12:42
@Eskibear
Copy link
Contributor

LGTM.

But sample setting of color customization in Wiki page should be updated. The standard modifier "readonly" has been used instead of "final".

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon force-pushed the semantic-highlighting-prompt branch from 0bf057b to e237e51 Compare April 29, 2020 16:00
@fbricon fbricon merged commit 6dea4dd into redhat-developer:master Apr 29, 2020
@fbricon fbricon added this to the End April 2020 milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants