Check for suspicious gradle-wrapper.jar #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
May 18, 2020
src/settings.ts
Outdated
| @@ -17,6 +17,9 @@ const changeItem = { | |||
| never: 'Never' | |||
| }; | |||
|
|
|||
| const allow = 'Allow'; | |||
| const disallow = 'Disallow'; | |||
snjeza
force-pushed
the
gradlewrapper
branch
5 times, most recently
from
677d930
to
95e162a
Compare
fbricon
requested changes
May 19, 2020
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
@fbricon I have update the PR. |
fbricon
changed the title
|
Before a Gradle wrapper is executed, its checksum is verified against the list of wrappers publicly released by the Gradle team. If the checksum doesn't match a known good checksum, a security warning is displayed (actually an error, so it stays visible):
The link opens the corresponding wiki page. If you trust the wrapper to be executed, the application settings.jon will be updated like: "java.imports.gradle.wrapper.checksums": [
{
"sha256": "504b38a11c466aecb2f5c0b0d8ce0ed7ffa810bf70b9b7a599c570051be8fb4e",
"allowed": true
}
],and the wrapper will be used. If you don't trust it, The default Gradle version embedded in Buildship will be used to build your project until the wrapper is explicitly trusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires eclipse-jdtls/eclipse.jdt.ls#1434
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com