Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune the user settings about specifying gradle distribution #1534

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

testforstephen
Copy link
Collaborator

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

Close #1495

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen
Copy link
Collaborator Author

// @akaroml @jdneo @Eskibear

@Eskibear
Copy link
Contributor

java.import.gradle.version: Use Gradle from the specific version if the Gradle wrapper is missing or disabled.

Just to confirm that, if java.import.gradle.wrapper.enabled is true, we don't honor java.import.gradle.version, right?

@testforstephen
Copy link
Collaborator Author

testforstephen commented Jul 20, 2020

Also if your project has gradle wrapper, then we don't respect java.import.gradle.version.

The extension follows the order below to find the gradle distribution:

  1. Check whether gradle.wrapper.enable preference is enabled and your workspace contains gradlew script.
  2. Check gradle.version perference.
  3. Check gradle.home preference and GRADLE_HOME environment variable.

@fbricon fbricon added this to the End July 2020 milestone Jul 20, 2020
@fbricon fbricon removed this from the End July 2020 milestone Jul 20, 2020
@fbricon fbricon added this to the End July 2020 milestone Jul 20, 2020
@fbricon fbricon merged commit 5959f1b into redhat-developer:master Jul 20, 2020
@fbricon
Copy link
Collaborator

fbricon commented Jul 20, 2020

Thanks @testforstephen

@testforstephen testforstephen deleted the jinbo_gradle branch July 20, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The gradle wrapper validator won't work in the machine without internet access
3 participants