Add test case for rename file #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| test('rename on file will update the class name', async function () { | ||
| const workspaceEdit: WorkspaceEdit = new WorkspaceEdit(); | ||
| workspaceEdit.renameFile(Uri.file(originFilePath), Uri.file(newFilePath)); | ||
| await workspace.applyEdit(workspaceEdit); |
There was a problem hiding this comment.
The unit test will modify the test project file in the source code directly. Can you copy it to some temporary directory and modify there?
fbricon
requested changes
Aug 24, 2020
|
Updated. |
Signed-off-by: Sheng Chen <sheche@microsoft.com>
|
Thanks @jdneo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent the regression in the future, for the issue: #1517
Signed-off-by: Sheng Chen sheche@microsoft.com