Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 'Hybrid' serverMode value in api #1586

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

rzgry
Copy link
Contributor

@rzgry rzgry commented Aug 20, 2020

Found it confusing that the serverMode api could return any of the server mode types defined in the ServerMode enum, but the extension api docs only mention Standard and Lightweight.

Signed-off-by: Ryan Zegray ryan.zegray@ibm.com

Signed-off-by: Ryan Zegray <ryan.zegray@ibm.com>
@testforstephen
Copy link
Collaborator

@jdneo Can you review this PR?

Copy link
Collaborator

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbricon fbricon merged commit 6fac46d into redhat-developer:master Aug 21, 2020
@fbricon
Copy link
Collaborator

fbricon commented Aug 21, 2020

Thanks @rzgry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants