Punctuation fix in import message #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'll be more consistent (at least, less weird) to use a period instead of a semicolon. |
|
That semicolon usage is standard English, though perhaps it looks strange to a French speaker? In any case, I'm happy to split it into two sentences. Force-pushing the change shortly. |
Signed-off-by: Paul Cantrell <cantrell@pobox.com>
pcantrell
force-pushed
the
import-message-copy-edit
branch
from
3a681d4
to
5875958
Compare
|
It's also standard French ;-) But we'd prolly need to rewrite a whole bunch of sentences all over the place to be consistent with that style. |
|
Fair enough! |
|
Thanks @pcantrell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor punctuation fix: these are two independent clauses, and thus joining them with a comma is incorrect in formal written English.
An alternative to the one in this PR would be two separate sentences:
…but I proposed the semicolon because it’s Java!