Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change scope of 'java.home' to machine-overridable #1676

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Change scope of 'java.home' to machine-overridable #1676

merged 1 commit into from
Nov 3, 2020

Conversation

jdneo
Copy link
Collaborator

@jdneo jdneo commented Oct 27, 2020

resolve #1667

Signed-off-by: Sheng Chen sheche@microsoft.com

@jdneo
Change scope of 'java.home' to machine-overridable
284b560 
Signed-off-by: Sheng Chen <sheche@microsoft.com>
testforstephen
testforstephen approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Since java.home points to an absolute path in current machine, naturally it's not shared across machines. machine-overridable looks fair, because it keeps the capability to override it with workspace settings, but stops it sharing to other machines.

@Eskibear Eskibear mentioned this pull request Nov 3, 2020
Merged
@fbricon fbricon merged commit 01cc378 into redhat-developer:master Nov 3, 2020
@fbricon fbricon added this to the End October 2020 milestone Nov 3, 2020
@jdneo jdneo deleted the cs/issue-1667 branch November 3, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
End October 2020
Development

Successfully merging this pull request may close these issues.

Change the scope of 'java.home' to machine-overridable?
3 participants
@jdneo @testforstephen @fbricon