-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Recommend dependency analytics extension #1771
feat: Recommend dependency analytics extension #1771
Conversation
6891206
to
44cd813
Compare
376792e
to
6f4178e
Compare
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
6f4178e
to
3e32aee
Compare
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
f72e2a4
to
6879acd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks fine. Just had one suggestion about avoiding excessive checks in the callbacks.
I also tried this on project with a large amount of poms ( https://git.eclipse.org/c/orbit/orbit-recipes.git/tree/ ) and it hit a timeout exception :
Failed to trigger application's stack analysis, try in a while. Status: 408 - REQUEST TIMEOUT
The analytics page came back empty with just the text "Unable to analyze your stack." . If this is expected in more extreme cases then I guess that's fine for now.
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
0ffd9e1
to
008101c
Compare
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
008101c
to
17ae046
Compare
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the issues.
I've tested each case, in addition to installing/uninstalling the analytics independent of the recommendation code. It seems to be doing the right thing each time.
Can you just squash the commits into 1 and then we can merge this.
UPDATE : I'll take care of the formatting.
Merged as bdacd43 . |
Changes are inspired by https://github.com/microsoft/vscode-java-pack/tree/master/src/recommendation.
Fixes #1763 https://issues.redhat.com/browse/APPAI-1628