-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use lightweight mode by default when vscode is running from web browsers #1780
use lightweight mode by default when vscode is running from web browsers #1780
Conversation
@rgrunber make sure this change doesn't break the Che/Theia integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely affects Theia. env.uiKind
is '2' (UIKind.Web
) so the various prompts are skipped. Perhaps env.appName
may need to be used to further narrow this down ?
I just tested some scenarios on VS Code, below are possible values I found:
So yes, we can check |
I may suggest |
0622d48
to
586dbce
Compare
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
586dbce
to
fa4f5f1
Compare
OK, I've updated the PR to check both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I can confirm Theia is excluded.
The purpose is to reduce pop-up notifications.
Here we remove the notification, and by default only launches LS in lightweight mode if vscode is running from a web browser. It's based on the hypothesis that when users open vscode on a web browser they mainly want to browse code or do simple editing.