-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Type Hierarchy #1790
Merged
testforstephen
merged 4 commits into
redhat-developer:master
from
CsCherrYY:TypeHierarchy
Mar 12, 2021
Merged
Support Type Hierarchy #1790
testforstephen
merged 4 commits into
redhat-developer:master
from
CsCherrYY:TypeHierarchy
Mar 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade version
@CsCherrYY could you please resolve the conflicts? |
Sure. |
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
force-pushed
the
TypeHierarchy
branch
from
March 10, 2021 05:34
cf566fc
to
5d83fd9
Compare
Signed-off-by: Shi Chen <chenshi@microsoft.com>
testforstephen
approved these changes
Mar 12, 2021
We should probably also update https://github.com/redhat-developer/vscode-java#features to include this. |
Sure. I'll create a PR then. |
Agree, actually there are some other features missed by README as well. We can update it in one PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires eclipse/eclipse.jdt.ls#1656
Will support showing type hierarchy. The user can open type hierarchy of a given type view via context of editor:
The type hierarchy view uses reference-viewlet-API and show the result in the reference view. The focus type is highlighted:
The type hierarchy has three kinds of hierarchies. Type Hierarchy, SuperType Hierarchy and SubType Hierarchy. The user can change the view via the buttons on the title of the view.
Also offer a command in the context of view to change the focus type:
Some notes:
/src/typeHierarchy/references-view.d.ts
is the API definition file from reference-viewlet-API. It's a stable version and will not break in the foreseeable future.Currently the type hierarchy icons of VS Code is not available yet. We use eclipse ones temporarily.We have applied vscode's type hierarchy icons.Signed-off-by: Shi Chen chenshi@microsoft.com