Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Type Hierarchy #1790

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Conversation

CsCherrYY
Copy link
Contributor

@CsCherrYY CsCherrYY commented Feb 3, 2021

Requires eclipse/eclipse.jdt.ls#1656

Will support showing type hierarchy. The user can open type hierarchy of a given type view via context of editor:
context

The type hierarchy view uses reference-viewlet-API and show the result in the reference view. The focus type is highlighted:
reference

The type hierarchy has three kinds of hierarchies. Type Hierarchy, SuperType Hierarchy and SubType Hierarchy. The user can change the view via the buttons on the title of the view.

Also offer a command in the context of view to change the focus type:
Focus

Some notes:

  • /src/typeHierarchy/references-view.d.ts is the API definition file from reference-viewlet-API. It's a stable version and will not break in the foreseeable future.
  • Currently the type hierarchy icons of VS Code is not available yet. We use eclipse ones temporarily. We have applied vscode's type hierarchy icons.

Signed-off-by: Shi Chen chenshi@microsoft.com

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@testforstephen
Copy link
Collaborator

@CsCherrYY could you please resolve the conflicts?

@CsCherrYY
Copy link
Contributor Author

Sure.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Shi Chen <chenshi@microsoft.com>
@testforstephen testforstephen merged commit bcd7dca into redhat-developer:master Mar 12, 2021
@testforstephen testforstephen added this to the End March 2021 milestone Mar 12, 2021
@CsCherrYY CsCherrYY deleted the TypeHierarchy branch March 15, 2021 08:47
@rgrunber
Copy link
Member

We should probably also update https://github.com/redhat-developer/vscode-java#features to include this.

@CsCherrYY
Copy link
Contributor Author

Sure. I'll create a PR then.

@testforstephen
Copy link
Collaborator

Agree, actually there are some other features missed by README as well. We can update it in one PR.

  • Go to Super Implementation
  • Call Hierarchy
  • Type Hierarchy

@CsCherrYY CsCherrYY restored the TypeHierarchy branch April 29, 2021 07:15
@CsCherrYY CsCherrYY deleted the TypeHierarchy branch March 18, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants