Set minimum for threshold settings #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <sheche@microsoft.com>
|
Do we need to fallback the value to default (99) when it's non-positive at JDT.LS? Since some users may manually edit settings in |
| @@ -641,12 +641,15 @@ | |||
| "type": "integer", | |||
| "description": "Specifies the number of imports added before a star-import declaration is used.", | |||
| "default": 99, | |||
| "scope": "window" | |||
| "scope": "window", | |||
| "minimum": 1 | |||
There was a problem hiding this comment.
We have guarded the negative case in server side. If zero is not legal, i think we need update the condition check in server side as well.
There was a problem hiding this comment.
PR raised: eclipse-jdtls/eclipse.jdt.ls#1715
fbricon
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix microsoft/vscode-java-pack#590
Signed-off-by: Sheng Chen sheche@microsoft.com