Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust .vscodeignore filters due to vsce@1.92 update. #1983

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Jun 16, 2021

Signed-off-by: Roland Grunberg rgrunber@redhat.com

Let me know if you're able to verify this (vsce ls should show what would be published). I noticed our snapshot builds doubled in size because, as an example, org.eclipse.jdt.ls.product/distro/jdt-language-server-1.2.0-202106160036.tar.gz would end up in our final .vsix despite **/**.tar.gz. Comparing the builds showed vsce 1.91 -> 1.93, and that lead to microsoft/vscode-vsce#576 .

So it looks like we should be using https://git-scm.com/docs/gitignore as a guide now. AFAICT **/dist/*.map should be covered by **/*.map since a leading ** implies all directories. Might even be possible to simplify to just *.map according to docs.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Copy link
Collaborator

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Have a try, an asterisk "*" (**/*.tar.gz) works both in 1.91 and 1.93. It's good to merge.

@fbricon fbricon added this to the Mid June 2021 milestone Jun 16, 2021
@fbricon fbricon merged commit 6fb91c3 into redhat-developer:master Jun 16, 2021
@rgrunber rgrunber deleted the fix-vscodeignore branch June 16, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants