Explicitly show import progress

[jdneo]

This is the first part of #2021.

In this PR:

• we show the job status more explicitly during the import stage. (Like Eclipse or IntelliJ, at the right-bottom corner, users can see what jobs are running)

• If user click the hyper link in the notification, the build status terminal will pop up and the notification get dismissed.

• After importing jobs are finished. A dialog shows up to let the user know.

import-progress.mp4

Signed-off-by: Sheng Chen sheche@microsoft.com

[fbricon]

need a preference to not show the progress

[jdneo]

need a preference to not show the progress

Ok

@rgrunber @snjeza @testforstephen @akaroml @Eskibear @CsCherrYY Since this change related to UX, feel free to let me know if you have any comments

[fbricon]

nitpick : can you please fix the typo in the commit message? (s/improt/import)

[jdneo]

nitpick : can you please fix the typo in the commit message? (s/improt/import)

Done, will have another commit to add the preference

[rgrunber]

Works well for me. Just a minor thing to address so far.

[jdneo]

About adding a setting to control the appearance of the progress notification.

I'm thinking that adding a setting called: java.showJobStatusOnStart, which has 3 options:

• notification: show the job status via notification on start (default)
• terminal: Show the job status via terminal on start
• off: Do not show the job status on start

Meanwhile, deprecated java.showBuildStatusOnStart.enabled. (Still working but consider to remove it after several iterations). What do you think?

[jdneo]

PR update, finally I use the anyOf mechanism in package.json to reuse the setting java.showBuildStatusOnStart.enabled meanwhile provides backwards compatibility. User can set it to:

• notification: Show the build status via progress notification.

• terminal: Show the build status via terminal.

• off: Do not show any build status.

  For backward compatibility, this setting also accepts boolean value, where true has the same meaning as notification and false has the same meaning as off.

Besides, the default value changes to notification

@fbricon @rgrunber

[rgrunber]

Change works well. Just one thing I noticed that may be annoying (given how much space the progress bar takes), although the same behaviour occurs with the status bar provider.

If you kill the syntax/standard server while it's importing/building the project (or it crashes), the progress notification will remain indefinitely on the screen. The restarted language server ultimately finishes the importing, but the progress bar remains. I think the same thing can happen for the status bar provider. I wonder if there's a way to deal with this.

[jdneo]

I can imagine that some users might not like these kind of pop-ups.

Or, maybe we can still use off as the default value and then in the terminal, always show some action links somewhere in it. One of the action is open the related setting to let user set the preference.

Anyway, we can discuss in our next sync meeting.

[jdneo]

PR updated to simplify the text.

Meanwhile, I created a new issue to track the item that dealing with the situation when server crashes

[rgrunber]

LGTM. Feel free to squash and merge when ready.

[jdneo]

Hi @rgrunber, Jinbo(@testforstephen) is the only person who has the permission to merge PRs on our side. He is now on vacation until next week.

If you plan to make a release in this week, maybe we need your help to merge. :)