Permit usage of javaagent (no prompt) if resource not in workspace #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May need to do some checking workspace.workspaceFolders but this seems to be working. |
sunix
reviewed
Aug 31, 2021
rgrunber
force-pushed
the
fix-1965
branch
3 times, most recently
from
9d3e446
to
b3823a7
Compare
|
I'll just need to test this in Theia to confirm it'd work as expected. |
|
ok let me know if you need some help to test it. |
- Fixes redhat-developer#1965 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
|
Ok, so I've verified this should work in Theia. In Theia, workspace trust is undefined, so in that case we check whether the agentFlag value is in the workspace. If so, we show the security prompt, and otherwise we allow it. If a client supports workspace trust, the entire security prompt should be skipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roland Grunberg rgrunber@redhat.com