Deprecate 'java.configuration.checkProjectSettingsExclusions' #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If users want to change the place to generate metadata files they can use 'java.import.generatesMetadataFilesAtProjectRoot'. - If users just want to hide the metadata files at the file explorer, they can use 'files.exclude' directly. Signed-off-by: Sheng Chen <sheche@microsoft.com>
fvclaus
pushed a commit
to fvclaus/vscode-java
that referenced
this pull request
Feb 18, 2022
…-developer#2311) - If users want to change the place to generate metadata files they can use 'java.import.generatesMetadataFilesAtProjectRoot'. - If users just want to hide the metadata files at the file explorer, they can use 'files.exclude' directly. Signed-off-by: Sheng Chen <sheche@microsoft.com> Signed-off-by: Frederik Claus <f.v.claus@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting
java.configuration.checkProjectSettingsExclusionswas introduced to mitigate the problem that metadata files are generated at the project root. Now since we havejava.import.generatesMetadataFilesAtProjectRootto completely solve the problem, I think it's a good time to deprecated it.This PR deprecates
java.configuration.checkProjectSettingsExclusions, and change its default value tofalse, so:java.import.generatesMetadataFilesAtProjectRoot.files.excludedirectly. Though I don't think it's a common case (explicitly let the metadata files generate at project root but hide them in the file explorer).Signed-off-by: Sheng Chen sheche@microsoft.com