Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added completion support for multiline comment blocks #2484

Merged
merged 3 commits into from
May 30, 2022

Conversation

JessicaJHee
Copy link
Contributor

Peek 2022-05-30 10-06

Fixes #2464

Signed-off-by: Jessica He jhe@redhat.com

Signed-off-by: Jessica He <jhe@redhat.com>
@fbricon
Copy link
Collaborator

fbricon commented May 30, 2022

Does /**|*/ (javadoc comment) still work?

@JessicaJHee
Copy link
Contributor Author

JessicaJHee commented May 30, 2022

Does /**|*/ (javadoc comment) still work?

Yes it does!

Peek 2022-05-30 10-18

src/extension.ts Outdated Show resolved Hide resolved
@rgrunber
Copy link
Member

rgrunber commented May 30, 2022

@snjeza you mentioned this would break /** in #2464 (comment) ? Can you explain ? To me it doesn't really break, so much as creates the closing term sooner so the user is responsible for determining if they want a javadoc, or just block comment, by deciding to type the extra *. If no other issues, I'd like to merge this eventually.

@fbricon
Copy link
Collaborator

fbricon commented May 30, 2022

* are not aligned, compared to javadoc behavior or in Eclipse.
You get

/*
* 
*/

instead of

/*
 * 
 */

Signed-off-by: Jessica He <jhe@redhat.com>
@rgrunber rgrunber added this to the Early June 2022 milestone May 30, 2022
@snjeza
Copy link
Contributor

snjeza commented May 30, 2022

you mentioned this would break /** in #2464 (comment) ? Can you explain ? To me it doesn't really break,

It works fine.
com

src/extension.ts Outdated Show resolved Hide resolved
@snjeza
Copy link
Contributor

snjeza commented May 30, 2022

  • are not aligned, compared to javadoc behavior or in Eclipse.
    You get...

@fbricon I can't reproduce the issue. It works fine for me.

@JessicaJHee
Copy link
Contributor Author

  • are not aligned, compared to javadoc behavior or in Eclipse.
    You get...

@fbricon I can't reproduce the issue. It works fine for me.

Sorry forgot to mention that it was fixed in the most recent commit.

Signed-off-by: Jessica He <jhe@redhat.com>
@rgrunber rgrunber merged commit 6711075 into redhat-developer:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add completion support for multiline comment blocks
4 participants