Avoid repeatedly setting busy and ready for language server status #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi Chen <chenshi@microsoft.com>
rgrunber
reviewed
Jun 9, 2022
There was a problem hiding this comment.
Seems reasonable. I can also see the flickering behaviour.
Logging the notifications when importing a maven project, I noticed many Busy and Ready notifications. In particular I saw some instances where Ready is sent even though it is already set. Can you confirm this as well. Might be worth doing the same for setReady.
|
I can also observe this via printing the notifications received.
multiple |
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
changed the title
rgrunber
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2493 , for frequently invoking of
setBusy().cc: @Eskibear