Verify that java.jdt.ls.java.home meets minimum JRE requirement. #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testforstephen
approved these changes
Jun 16, 2022
Ok, I will add this in before merging. |
- java.jdt.ls.java.home should only be used if it meets the minimum JRE requirement - Default to the embedded JRE (if available) otherwise - Display one-time notification message to inform that JVM set within 'java.jdt.ls.java.home' could not be used Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
validate-java-home
branch
from
4c4a4fa
to
79fe49d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.jdt.ls.java.hometo some value (eg./usr/lib/jvm/java-11-openjdk/).requirement
Signed-off-by: Roland Grunberg rgrunber@redhat.com
@fbricon , @testforstephen , let me know if I've missed something here.
Update : Maybe there's an argument to be made for a notification given that we're ignoring the expected behaviour (of using the
java.jdt.ls.java.homevalue) ?