Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to clean workspace without pop-up notification #2514

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

testforstephen
Copy link
Collaborator

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

This won't affect the UX when triggering it from command palette. It's used for side extensions, where we need to invoke "Clean Workspace" command in some failing case. Giving an option "force" is used to avoid poping up notification multiple times.

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just an API addition that is no-op on this end.

@rgrunber rgrunber merged commit d95b796 into redhat-developer:master Jun 17, 2022
@rgrunber rgrunber added this to the End June 2022 milestone Jun 17, 2022
@rgrunber rgrunber added the API label Jun 17, 2022
@testforstephen testforstephen deleted the jinbo_clean branch June 18, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants