Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rebuild selected projects #2526

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Conversation

jdneo
Copy link
Collaborator

@jdneo jdneo commented Jun 23, 2022

part of #2510, requires eclipse-jdtls/eclipse.jdt.ls#2138

  • Add a new extended LSP request: BuildProjectRequest.
  • the request param has two fields: identifiers - uri and isFullBuild - boolean.

Currently, isFullBuild is always set to true. Since we enable auto-build by default, triggering an incremental build does not make much sense. But a clean full build is helpful when the build status is out of sync. In the future, if users ask for incremental build support, we can expose this param.

The name of the command is called Rebuild Projects now, indicates it will clean and do a full build.

Signed-off-by: sheche sheche@microsoft.com

- Add a new extended LSP request: BuildProjectRequest.
- The 'isFullBuild' is set to true by default in the request param.

Signed-off-by: sheche <sheche@microsoft.com>
Signed-off-by: sheche <sheche@microsoft.com>
src/commands.ts Outdated Show resolved Hide resolved
src/standardLanguageClient.ts Outdated Show resolved Hide resolved
Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo
Copy link
Collaborator Author

jdneo commented Jun 29, 2022

@CsCherrYY PR updated. Meanwhile, I also make the first argument of the command either Uri[] or Uri to make it easier to call via executeCommand()

Signed-off-by: Sheng Chen <sheche@microsoft.com>
Copy link
Contributor

@CsCherrYY CsCherrYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo jdneo merged commit 5d1c872 into redhat-developer:master Jun 29, 2022
@jdneo jdneo deleted the cs/issue-2510 branch June 29, 2022 07:14
@jdneo jdneo mentioned this pull request Jun 29, 2022
@rgrunber rgrunber added this to the End June 2022 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants