-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prerelease and platform-specific publishing for Open VSX #2587
Add prerelease and platform-specific publishing for Open VSX #2587
Conversation
Signed-off-by: Filip Tron铆膷ek <filip@gitpod.io>
7a86f21
to
9221ac6
Compare
I noticed a little while ago that I guess we need to play with it in VS Codium to confirm. If it all looks good, I'll merge this proposal. As a note, we add the pre-release option in the |
Hi @rgrunber! We did indeed add these features back in March, but the deployment pipeline has been causing some real big issues there. We actually deployed when I raised this PR, but since then had to revert and go back because the entirety of https://open-vsx.org went down 馃槙.
Do you mean "seperated" as in the UI of Open VSX, the backend or inside VS Code? Inside VS Code, pre-release versions are only a part of the pre-release channel the same way as the Microsoft Marketplace. In the UI, all versions are included in the extensions's UI (stable & pre-release), but they are clearly marked and users can always easily switch to the latest stable version if they are viewing a pre-release.
I will test the latest version in Gitpod and can do testing in VS Codium too, I will do that hopefuly soon 馃. As for the remainder of your comments, I will take a look 馃檪. |
Signed-off-by: Filip Tron铆膷ek <filip@gitpod.io> Remove enclosing `for` loop Signed-off-by: Filip Tron铆膷ek <filip@gitpod.io>
fb76a02
to
3f8b8d6
Compare
Ok, so I finally tried out VSCodium. Here's what I saw in side-by-side comparison. In VSCode, I wasn't able to install Jbang using the standard install button as it only has contributed pre-releases. There's a separate context menu from the install button that allows one to switch to installing pre-releases. In VSCodium the install proceeded without issue, and you can see there is no indication that what I installed was a pre-release. I can confirm the .vsixmanifest of the installed extension does have : Another oddity I noticed : $ diff -u ~/.vscode/extensions/jbangdev.jbang-vscode-0.1.2022083013/package.json ~/.vscode-oss/extensions/jbangdev.jbang-vscode-0.1.2022083013/package.json
--- /home/rgrunber/.vscode/extensions/jbangdev.jbang-vscode-0.1.2022083013/package.json 2022-08-30 13:57:46.468862902 -0400
+++ /home/rgrunber/.vscode-oss/extensions/jbangdev.jbang-vscode-0.1.2022083013/package.json 2022-08-31 16:05:58.302289497 -0400
@@ -120,14 +120,14 @@
"vscode-languageclient": "^8.0.1"
},
"__metadata": {
- "id": "...",
- "publisherId": "...",
- "publisherDisplayName": "JBang",
+ "id": "...",
+ "publisherId": "...",
+ "publisherDisplayName": null,
"targetPlatform": "undefined",
"isApplicationScoped": false,
- "updated": true,
- "isPreReleaseVersion": true,
- "preRelease": true,
- "installedTimestamp": 1661882266468
+ "updated": false,
+ "isPreReleaseVersion": false,
+ "preRelease": false,
+ "installedTimestamp": 1661976358301
}
}
\ No newline at end of file I didn't find these values in the vsix itself, so I suspect they might come from the marketplace server. I think if there was some indication or action users had to take to make it clear they are now using a pre-release, it would be good. @fbricon , thoughts ? |
For some context, pre-releases can contain pre-released versions of tooling/features, and it isn't ideal to mark them as a regular releases, prior to upstream officially announcing them. I think this needs to be resolved in Maybe we could look at the platform-specific aspect of this change though. |
@rgrunber Open VSX now supports pre-releases and target platforms. |
@amvanbaren indeed it works. VS Codium now proposes to switch to the Pre-Release version of JBang. |
@rgrunber just a quick FYI: platform-specific extensions should be good to go now, we deployed https://open-vsx.org recently so this PR is no longer blocked 馃帀. |
I'm going to be testing out a change that simplifies the Jenkinsfile, and hopefully is able to also perform package-specific+pre-releases on Open VSX. My motivation is basically that the current state of the Jenkinsfile is really difficult to read and comprehend. We have a lot of odd states that were kept a certain way in part because of the different vsix requirements between VS Code Marketplace & Open VSX. With both supporting the pre-release/package-specific vsixs we should try to make the build file simpler. |
Just published a package-specific pre-release to https://open-vsx.org/extension/redhat/java . More info can be seen at https://open-vsx.org/api/redhat/java/1.13.2022102814 . On I'll create a new PR once it looks like this is correct, though I don't see anything off about the packages/metadata. I may also ask @CsCherrYY to review as he published some of the original work in the Jenkinsfile to do this (back when the different requirements between registries required workarounds). |
Hi there, an Open VSX commiter here 馃憢!
Context
Open VSX has today deployed a change adding the ability to do both pre-releases and platform-specific extensions the same way the Microsoft (VS Code) Marketplace handles them.
This PR adds publishing of both of these to the Jenkins file. Mainly the platform-specific releases will help a bunch with their integrated JREs in some environments.
P.S.: I have never written Jenkins jobs before so this may need a small review.