Add an option to enable/disable null analysis #2747
Conversation
CsCherrYY
force-pushed
the
cs-null-mode
branch
from
7b6f271
to
0482f4d
Compare
|
Since switching between |
CsCherrYY
changed the title
package.json
Outdated
| "automatic" | ||
| ], | ||
| "default": "disabled", | ||
| "markdownDescription": "Specify how to enable the annotation-based null analysis. When set to `interactive`, you will have a chance to turn on the null analysis when the null annotations are detected in your project dependencies.", |
There was a problem hiding this comment.
I wonder if we need to explain what happens when interactive is set. If you look at other options we have (eg. java.configuration.updateBuildConfiguration, java.project.importOnFirstTimeStartup) that use interactive, we never go into details. Maybe it's understood that the setting implies some kind of UI prompt when the capability is about to change/enable.
Also, there's 3 other places in previous changes where we use ".. if it exists in your project dependencies". I would avoid this in favour of just ".. if it exists in project dependencies"
There was a problem hiding this comment.
Yeah, let me remove the detail description of interactive and make the phase more readable.
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
force-pushed
the
cs-null-mode
branch
from
c51fbdf
to
6de60a5
Compare
|
Is |
|
looks like an outdated configuration name, let me correct it. |
Signed-off-by: Shi Chen chenshi@microsoft.com
requires eclipse-jdtls/eclipse.jdt.ls#2279
add new preference java.compile.nullAnalysis.mode.