Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings for some more cleanups. #2827

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Dec 5, 2022

  • addFinalModifier: Add final modifier where possible
  • instanceofPatternMatch: Use pattern matching for instanceof checks
  • lambdaExpression: Convert anonymmous class usage to lambda expressions
  • switchExpression: Convert switch statement to switch expression

This change requires eclipse-jdtls/eclipse.jdt.ls#2350

Signed-off-by: Roland Grunberg rgrunber@redhat.com

- addFinalModifier: Add final modifier where possible
- instanceofPatternMatch: Use pattern matching for instanceof checks
- lambdaExpression: Convert anonymmous class usage to lambda expressions
- switchExpression: Convert switch statement to switch expression

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber
Copy link
Member Author

rgrunber commented Dec 5, 2022

Starting to wonder if we should sort these ..

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, Roland!

@rgrunber rgrunber added this to the Early January 2023 milestone Dec 7, 2022
@rgrunber rgrunber merged commit aa44a59 into redhat-developer:master Dec 7, 2022
@rgrunber rgrunber deleted the easy-cleanups branch December 7, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants