Clarify the README quick start instructions. #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
approved these changes
Feb 7, 2023
- Be more clear about when the extension is expected to work without any setup, and when setting a JDK is required - Make it more clear that configuring a project JDK is optional Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
readme-jdk-reword
branch
from
7724ed8
to
121fe37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roland Grunberg rgrunber@redhat.com
In #2837 (comment), @phaumer mentioned that our instructions don't mention anything about the universal vsix requiring Java 17 as a minimum to start up.
I've reworded the quick start to make it a bit more clear. The tricky part is it's a "quick start" so it's not meant to go into too much detail on every possible scenario.