Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github action to detect potential duplicate issues #2927

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Feb 9, 2023

  • Duplicate detection is only performed against the issue title.
  • it's only triggered on new issues or when the issue title is edited

Signed-off-by: Fred Bricon fbricon@gmail.com

Signed-off-by: Fred Bricon <fbricon@gmail.com>
# Comment to post when potential duplicates are detected.
comment: |
We have found issues that are potential duplicates: {{#issues}}
- #{{ number }} ({{ accuracy }}%)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this pattern renders fine on the Web UI:
Screenshot 2023-02-09 at 11 54 04

But the problem is emails are then missing the title, like

We have found issues that are potential duplicates:

If any of the issues listed above are a duplicate, please consider closing this issue & upvoting/commenting the original one.
Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

So if we use #{{ number }} {{title}} ({{ accuracy }}%), emails are fine but we get duplicate titles in the Web UI
and if we use [{{number}} {{title}}](#{{ number }}) ({{ accuracy }}%), emails and web UI both show the title, but we lose the issue status on the Web UI

Screenshot 2023-02-09 at 12 02 18

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have found issues that are potential duplicates:

If any of the issues listed above are a duplicate, please consider closing this issue & upvoting/commenting the original one.
Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

Not having the title in email is fine for me. It's nice to have that. Eventually, the user has to jump to the duplicate issue to further check if it's a duplicate.

@fbricon fbricon added this to the Mid February 2023 milestone Feb 9, 2023
@fbricon fbricon merged commit d864ead into redhat-developer:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants