fix type hierarchy regression since VS Code 1.75.1 #2930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open a Type Hierarchy in a given type will shows an error editor. But it works in VS Code 1.75.0 and before.
Root cause:
TypeHierarchyModel.location()
, we should useUri.parse()
instead ofUri.file()
since we're usingjdt
scheme to express class types. Before VS Code 1.75.1, this method will not be called since we bind correct Uri in the tree item command:vscode-java/src/typeHierarchy/model.ts
Lines 122 to 128 in a5a061f
TypeHierarchyModel.location()
will be called, causing this bug.