Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover when 'documentPaste' API is not properly registered. #3028

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Mar 28, 2023

Certain VS Code based clients (eg. VSCodium, or any rebuild of VSCode with different product file) may not have registered the document paste event API, so we should continue gracefully.

2023-03-28 18:12:57.959 [error] [Extension Host] Notification handler 'language/status' failed with message: Extension 'redhat.java' CANNOT use API proposal: documentPaste.
Its package.json#enabledApiProposals-property declares: [] but NOT documentPaste.
 The missing proposal MUST be added and you must start in extension development mode or use the following command line switch: --enable-proposed-api redhat.java

CC: @CsCherrYY let me know if this makes sense.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber requested a review from datho7561 March 28, 2023 23:29
@CsCherrYY
Copy link
Contributor

Tried in my PC, I can confirm that this patch can gracefully catch the exception and there is no such error in the extension host any more.

@rgrunber rgrunber removed the request for review from datho7561 March 29, 2023 03:25
@rgrunber rgrunber added this to the Early April 2023 milestone Mar 29, 2023
@rgrunber rgrunber merged commit cab4f38 into redhat-developer:master Mar 29, 2023
2 checks passed
@rgrunber rgrunber deleted the fix-pasteevent branch March 29, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants