Use choice syntax as placeholder for method/field snippets. #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
reviewed
Jun 7, 2023
rgrunber
reviewed
Jun 7, 2023
hopehadfield
force-pushed
the
method-snippet
branch
from
5b5bd4a
to
91874f3
Compare
rgrunber
changed the title
hopehadfield
force-pushed
the
method-snippet
branch
from
91874f3
to
92c5f81
Compare
rgrunber
changed the title
rgrunber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of the individual
public_method,private_method,protected_method,public_static_method, andprivate_static_methodsnippets and instead replaces them with a singlemethodsnippet, with choices for public/private/protected and static/non-static.Additionally,
prfsnippet is removed and replaced withfieldsnippet, with options for public/private/protected.