Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 3rd party extensions to track errors in language client & server #3162

Merged

Conversation

testforstephen
Copy link
Collaborator

Track the language client & server errors to improve the reliability of the product.

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@rgrunber
Copy link
Member

rgrunber commented Jun 22, 2023

Looking at it, I think this is fine, so feel free to merge. The only thing I can think of is that there are a few other places where error message may be encountered :

initializationFailedHandler: error => {

(the return true case from above might be particularly dangerous as that used to result in a stack overflow for a disposed connection but could be interesting to know how/if the client is failing to initialize the connection)

case MessageType.Error:

Are any of these interesting to also report, or would you intend to do that in a separate PR.

@testforstephen
Copy link
Collaborator Author

let's use a separate PR to cover more errors on client side.

@testforstephen testforstephen merged commit 34c5219 into redhat-developer:master Jun 25, 2023
2 checks passed
@testforstephen testforstephen deleted the jinbo_traceEvent branch June 25, 2023 05:25
@rgrunber rgrunber added this to the End June 2023 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants