Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically register VMInstalls for the JDKs installed on the local machine #3251

Merged

Conversation

testforstephen
Copy link
Collaborator

  • Use to jdk-utils lib to detect the JDKs installed on the local machine and add them to the “java.configuration.runtimes” setting. The JVMs configured in settings.json have higher priority. The server will automatically register them as VMInstalls.
  • If there are multiple JDKs with the same version on the local machine, use the following order to select one as the active JVM:
    "[JDK_HOME, JAVA_HOME, PATH] > [SDKMAN, jEnv, jabba, asdf] > Common places > Others (~/.gradle/jdks)"
  • We chose to use the nodejs library to detect the JDK because it enables the client to offer a JDK configuration UI in the future, which would give more transparency about the JDK information.

… machine

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@fbricon
Copy link
Collaborator

fbricon commented Aug 22, 2023

it should probably disable the JDT built-in JDK detection mechanism then

Copy link
Contributor

@snjeza snjeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@testforstephen
Copy link
Collaborator Author

it should probably disable the JDT built-in JDK detection mechanism then

make sense, fixed.

@testforstephen testforstephen added this to the End August 2023 milestone Aug 23, 2023
@testforstephen testforstephen merged commit 6cc071a into redhat-developer:master Aug 23, 2023
2 checks passed
@testforstephen testforstephen deleted the jinbo_vmDetection branch August 23, 2023 07:29
rgrunber added a commit that referenced this pull request Sep 13, 2023
rgrunber added a commit that referenced this pull request Sep 13, 2023
testforstephen added a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants