Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make intrusive language server output less intrusive #326

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

bawachhe
Copy link
Contributor

Every single time I remove lines or characters of code from a java file, the Language Server outputs a BadLocationException, which always interrupts my typing by popping up VSCode's output panel, and the only real solution seems to be to resize that panel to as little height as possible. I've recently experienced different issues with stale filenames, which result in a FileNotFoundException. Error this, exception that, and every time I attempt to navigate a java file, it seems, I am interrupted by another complaint from the Language Server. This is untenable.

I tested this feature on VSCode v1.17.0 and it worked. The output window still shows issues that the Language Server has, but it no longer interrupts me.

This issue has been very frustrating and exasperating for me and many others for some time. While the exceptions themselves should be tracked down and fixed, they are separate issues to the user experience failure that is the output window consistently interrupting me, so please consider as such and merge/release this modification.

@fbricon
Copy link
Collaborator

fbricon commented Oct 12, 2017

@bawachhe thanks for your contribution! Before we can proceed with merging it, can you please sign your commit? See https://github.com/probot/dco#how-it-works

@fbricon
Copy link
Collaborator

fbricon commented Oct 12, 2017

@bawachhe your PR fails to build. See https://travis-ci.org/redhat-developer/vscode-java/jobs/286787939

src/extension.ts(58,51): error TS2551: Property 'never' does not exist on type 'typeof RevealOutputChannelOn'. Did you mean 'Never'?

Signed-off-by: Brent Krone-Schmidt <brent.krone-schmidt@liferay.com>
@bawachhe
Copy link
Contributor Author

I fixed everything.

@fbricon fbricon merged commit 78f4d66 into redhat-developer:master Oct 12, 2017
@fbricon fbricon added this to the Mid October 2017 milestone Oct 12, 2017
@fbricon
Copy link
Collaborator

fbricon commented Oct 12, 2017

@bawachhe thanks again for your PR!

We'll keep on working towards resolving #314. Once we stabilize the server's behaviour, we'll see if showing the output on errors becomes acceptable, eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants